Skip to content

bpo-30070: Fixed leaks and crashes in errors handling in the parser module. #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 6 commits into from
Apr 19, 2017
Merged

bpo-30070: Fixed leaks and crashes in errors handling in the parser module. #1131

serhiy-storchaka merged 6 commits into from
Apr 19, 2017

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 14, 2017

No description provided.

@serhiy-storchaka serhiy-storchaka added type-bug An unexpected behavior, bug, or error needs backport to 2.7 labels Apr 14, 2017
@mention-bot
Copy link

mention-bot commented Apr 14, 2017

@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @freddrake, @loewis and @benjaminp to be potential reviewers.

@louisom
Copy link
Contributor

louisom commented Apr 17, 2017

@serhiy-storchaka May I ask a question? How did you found this bug, is via valgrind or something else? thanks.

@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Apr 17, 2017

Just by reading a code. I searched unchecked usages of PyObject_Size()/PySequence_Size()/PyMapping_Size() for bpo-30061 and after finding few suspicious cases in parsermodule.c analyzed other code in that file.

louisom
louisom reviewed Apr 17, 2017
View reviewed changes
Copy link
Contributor

@louisom louisom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small question about ref

Modules/parsermodule.c
PyObject *err = Py_BuildValue("Os", tuple,
"Illegal component tuple.");
PyErr_SetObject(parser_error, err);
Py_XDECREF(err);
Copy link
Contributor

@louisom louisom Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should tuple need Py_DECREF too? like what you done at line 950

Copy link
Member Author

@serhiy-storchaka serhiy-storchaka Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. tuple is a borrowed reference here (it's a parameter of build_node_tree()).

Copy link
Contributor

@louisom louisom Apr 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I see. didn't notice this. Thanks for your explain!

@serhiy-storchaka serhiy-storchaka merged commit a79f4c2 into python:master Apr 19, 2017
@serhiy-storchaka serhiy-storchaka deleted the parsermodule-errors-handling branch April 19, 2017 18:09
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Apr 19, 2017
@serhiy-storchaka
[3.6] bpo-30070: Fixed leaks and crashes in errors handling in the pa…
34d96ce 
…rser module. (pythonGH-1131).

(cherry picked from commit a79f4c2)
@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 19, 2017
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Apr 19, 2017
@serhiy-storchaka
[3.5] bpo-30070: Fixed leaks and crashes in errors handling in the pa…
4df77d1 
…rser module. (pythonGH-1131).

(cherry picked from commit a79f4c2)
@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 19, 2017
Merged
serhiy-storchaka added a commit that referenced this pull request Apr 19, 2017
@serhiy-storchaka
[3.6] bpo-30070: Fixed leaks and crashes in errors handling in the pa…
39dedb6 
…rser module. (GH-1131). (#1184)

(cherry picked from commit a79f4c2)
serhiy-storchaka added a commit that referenced this pull request Apr 19, 2017
@serhiy-storchaka
[3.5] bpo-30070: Fixed leaks and crashes in errors handling in the pa…
952a05e 
…rser module. (GH-1131). (#1185)

(cherry picked from commit a79f4c2)
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Apr 19, 2017
@serhiy-storchaka
[2.7] [3.5] bpo-30070: Fixed leaks and crashes in errors handling in …
27f3b1b 
…the parser module. (pythonGH-1131). (pythonGH-1185)

(cherry picked from commit a79f4c2).
(cherry picked from commit 952a05e)
@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 19, 2017
Merged
serhiy-storchaka added a commit that referenced this pull request Apr 19, 2017
@serhiy-storchaka
[2.7] [3.5] bpo-30070: Fixed leaks and crashes in errors handling in …
2a1bf06 
…the parser module. (GH-1131). (GH-1185) (#1189)

(cherry picked from commit a79f4c2).
(cherry picked from commit 952a05e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminp benjaminp Awaiting requested review from benjaminp

1 more reviewer

@louisom louisom louisom left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@serhiy-storchaka @mention-bot @louisom @Mariatta @the-knights-who-say-ni