bpo-35633: test_lockf() fails with "PermissionError: [Errno 13] Permission denied" on AIX #11424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
On 04/01/2019 13:32, Emmanuel Arias wrote:
eamanu approved this pull request.
LGTM. News?
afaik - for a 'test' a Misc/News blurb is not always needed. However,
just ask and I'll add something similar to the subject line.
|
aixtools
changed the title
Contributor
Author
|
Modified the PR per request (and also removed NEWS, so need "skip news" tag). Thx. |
Contributor
Author
|
p.s. earlier it was said a blurb was not needed. If so, could someone please "skip news" label? |
Mariatta
approved these changes
Feb 14, 2019
Contributor
|
Thanks @aixtools for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
Member
|
Thanks! |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 14, 2019
…ssion denied" on AIX (pythonGH-11424) [bpo-35633](https://bugs.python.org/issue35633): Fix a test regression introduced with [bpo-35189](https://bugs.python.org/issue35189) (PEP 475: fnctl functions are not retried if interrupted (EINTR)). Not only a blocking IO error needs to be ignored - permission errors also need to be ignored. p.s. - iirc as a "test" only correction a NEWS item is not required. If this is not correct - just mention, and I'll add a NEWS blurb. https://bugs.python.org/issue35633 (cherry picked from commit b94d4be) Co-authored-by: Michael Felt <[email protected]>
|
GH-11858 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Feb 14, 2019
…ssion denied" on AIX (GH-11424) [bpo-35633](https://bugs.python.org/issue35633): Fix a test regression introduced with [bpo-35189](https://bugs.python.org/issue35189) (PEP 475: fnctl functions are not retried if interrupted (EINTR)). Not only a blocking IO error needs to be ignored - permission errors also need to be ignored. p.s. - iirc as a "test" only correction a NEWS item is not required. If this is not correct - just mention, and I'll add a NEWS blurb. https://bugs.python.org/issue35633 (cherry picked from commit b94d4be) Co-authored-by: Michael Felt <[email protected]>
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bpo-35633: Fix a test regression introduced with bpo-35189 (PEP 475: fnctl functions are not retried if interrupted (EINTR)).
Not only a blocking IO error needs to be ignored - permission errors also need to be ignored.
p.s. - iirc as a "test" only correction a NEWS item is not required. If this is not correct - just mention, and I'll add a NEWS blurb.
https://bugs.python.org/issue35633