Skip to content

gh-76763: Make chr() always raising ValueError for out-of-range values #114882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
serhiy-storchaka merged 2 commits into from
Feb 10, 2024
Merged

gh-76763: Make chr() always raising ValueError for out-of-range values #114882

serhiy-storchaka merged 2 commits into from
Feb 10, 2024

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Feb 1, 2024 •
edited by bedevere-app bot
Loading

Previously it raised OverflowError for very large or very small values.

@serhiy-storchaka
pythongh-76763: Make chr() always raising ValueError for out-of-range…
d415909 
… values

Previously it raised OverflowError for very large or very small values.
@bedevere-app bedevere-app bot mentioned this pull request Feb 1, 2024
Closed
@ericsnowcurrently ericsnowcurrently removed their request for review February 2, 2024 00:26
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Feb 2, 2024

@vstinner, it has the same effect to your #5218, but without raising and catching an OverflowError.

mdickinson
mdickinson approved these changes Feb 10, 2024
View reviewed changes
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@serhiy-storchaka serhiy-storchaka merged commit e2c4038 into python:main Feb 10, 2024
@serhiy-storchaka serhiy-storchaka deleted the chr-overflow branch February 10, 2024 10:21
fsc-eriker pushed a commit to fsc-eriker/cpython that referenced this pull request Feb 14, 2024
@serhiy-storchaka @fsc-eriker
pythongh-76763: Make chr() always raising ValueError for out-of-range…
f7d2872 
… values (pythonGH-114882)

Previously it raised OverflowError for very large or very small values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eendebakpt eendebakpt eendebakpt left review comments

@vstinner vstinner Awaiting requested review from vstinner

+1 more reviewer

@mdickinson mdickinson mdickinson approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka @mdickinson @eendebakpt