[3.11] gh-115570: Fix DeprecationWarnings in test_typing #115571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
requested review from
AlexWaygood and
gvanrossum
as code owners
AlexWaygood
reviewed
Feb 16, 2024
Co-authored-by: Alex Waygood <[email protected]>
AlexWaygood
reviewed
Feb 16, 2024
Co-authored-by: Alex Waygood <[email protected]>
serhiy-storchaka
approved these changes
Feb 16, 2024
Member
|
Should this be forward-ported to Python 3.12? Python 3.12.2 (v3.12.2:6abddd9f6a, Feb 6 2024, 17:02:06) [Clang 13.0.0 (clang-1300.0.29.30)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import typing
>>> typing.io
<class 'typing.io'>
>>> typing.io.__doc__
<stdin>:1: DeprecationWarning: typing.io is deprecated, import directly from typing instead. typing.io will be removed in Python 3.12.
'Wrapper namespace for IO generic classes.'(The deprecation warning on Python 3.12 should also probably be updated: it obviously wasn't removed in Python 3.12. But it has been in Python 3.13.) |
Member
Author
|
Ah yes, I forgot we didn't remove this in 3.12. |
JelleZijlstra
added a commit
to JelleZijlstra/cpython
that referenced
this pull request
Feb 16, 2024
…n#115571) Co-authored-by: Alex Waygood <[email protected]>
|
GH-115574 is a backport of this pull request to the 3.12 branch. |
JelleZijlstra
added a commit
to JelleZijlstra/cpython
that referenced
this pull request
Feb 16, 2024
…n#115571) Co-authored-by: Alex Waygood <[email protected]>
JelleZijlstra
added a commit
that referenced
this pull request
Feb 16, 2024
…115574) Co-authored-by: Alex Waygood <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.