Skip to content

[3.6] bpo-35746: Fix segfault in ssl's cert parser (GH-11569) #11573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ned-deily merged 1 commit into from
Jan 16, 2019
Merged

[3.6] bpo-35746: Fix segfault in ssl's cert parser (GH-11569) #11573

ned-deily merged 1 commit into from
Jan 16, 2019

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Jan 15, 2019 •
edited by bedevere-bot
Loading

Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL
distribution points with empty DP or URI correctly. A malicious or buggy
certificate can result into segfault.

Signed-off-by: Christian Heimes [email protected]

https://bugs.python.org/issue35746
(cherry picked from commit a37f524)

Co-authored-by: Christian Heimes [email protected]

https://bugs.python.org/issue35746

@tiran @miss-islington
bpo-35746: Fix segfault in ssl's cert parser (pythonGH-11569)
bc947d7 
Fix a NULL pointer deref in ssl module. The cert parser did not handle CRL
distribution points with empty DP or URI correctly. A malicious or buggy
certificate can result into segfault.

Signed-off-by: Christian Heimes <[email protected]>

https://bugs.python.org/issue35746
(cherry picked from commit a37f524)

Co-authored-by: Christian Heimes <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Jan 15, 2019
Merged
@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 15, 2019

@tiran: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 15, 2019

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..

@alex
Copy link
Member

alex commented Jan 15, 2019

@ned-deily I think you need to approve this?

@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 16, 2019

@tiran: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor Author

miss-islington commented Jan 16, 2019

Sorry, I can't merge this PR. Reason: You're not authorized to push to this branch. Visit https://help.github.com/articles/about-protected-branches/ for more information..

@ned-deily ned-deily merged commit 216a4d8 into python:3.6 Jan 16, 2019
@miss-islington miss-islington deleted the backport-a37f524-3.6 branch January 16, 2019 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tiran tiran tiran approved these changes

Assignees

No one assigned

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miss-islington @alex @tiran @ned-deily @the-knights-who-say-ni @bedevere-bot