gh-93502: Add new C-API functions to trace object creation and destruction #115945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
tracerefs_interface
branch
2 times, most recently
from
c975033 to
a7a7653
Compare
pablogsal
force-pushed
the
tracerefs_interface
branch
from
dacd932 to
ae9c004
Compare
vstinner
reviewed
Mar 14, 2024
Member
|
@pablogsal: Sorry for late review, I missed your notification and then I lost it. |
Co-authored-by: Victor Stinner <[email protected]>
Member
Author
|
@vstinner I addressed your feedback, do you mind taking a look before beta freeze? |
vstinner
approved these changes
May 1, 2024
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. Here are some suggestions.
| setting the trace functions in all threads. | ||
| .. versionadded:: 3.12 | ||
Member
There was a problem hiding this comment.
I suggest to add a new section and just put the "versionadded:: 3.13" just after.
Example: "Reference Tracing".
Co-authored-by: Victor Stinner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_Py_NewReferencefor other tracers #93502