Skip to content

gh-116012: Preserve GetLastError() across calls to TlsGetValue on Windows #116014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zooba merged 1 commit into from
Feb 28, 2024
Merged

gh-116012: Preserve GetLastError() across calls to TlsGetValue on Windows #116014

zooba merged 1 commit into from
Feb 28, 2024

Conversation

@zooba
Copy link
Member

@zooba zooba commented Feb 27, 2024 •
edited by bedevere-app bot
Loading

@zooba zooba marked this pull request as ready for review February 27, 2024 23:22
@bedevere-app bedevere-app bot mentioned this pull request Feb 27, 2024
Closed
@zooba
Copy link
Member Author

zooba commented Feb 27, 2024

PyThread_get_key_value is deprecated and so is not getting an update. We don't use it internally that I can see.

ericsnowcurrently
ericsnowcurrently approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zooba zooba merged commit 9578288 into python:main Feb 28, 2024
@zooba zooba deleted the gh-116012 branch February 28, 2024 13:58
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
@zooba @woodruffw
pythongh-116012: Preserve GetLastError() across calls to TlsGetValue …
f7abcd2 
…on Windows (pythonGH-116014)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@zooba @adorilson
pythongh-116012: Preserve GetLastError() across calls to TlsGetValue …
eb14597 
…on Windows (pythonGH-116014)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@zooba @diegorusso
pythongh-116012: Preserve GetLastError() across calls to TlsGetValue …
7732e6b 
…on Windows (pythonGH-116014)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zooba @ericsnowcurrently