bpo-35713: Reorganize sys module initialization #11658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reorganize Python initialization to get working exceptions and sys.stderr earlier. Changes: * Add _PySys_SetPreliminaryStderr(). Preliminary sys.stderr is now set earlier to get an usable sys.stderr ealier. * Split _PyExc_Init(): create a new _PyBuiltins_AddExceptions() function. * Call _PyExc_Init() earlier in _Py_InitializeCore_impl() and new_interpreter() to get working exceptions earlier. * Split _Py_InitializeCore_impl() into subfunctions: add multiple pycore_init_xxx() functions * Move code into _Py_Initialize_ReconfigureCore() to be able to call it from _Py_InitializeCore(). * Rename _Py_ReadyTypes() to _PyTypes_Init(). * Rename _PySys_BeginInit() to _PySys_InitCore() * Rename _PySys_EndInit() to _PySys_InitMain() * Add _PySys_Create(). It calls _PySys_InitCore() which becomes private. * Misc code cleanup
Member
Author
|
PR rebased on master (to include commit 6d43f6f). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganize Python initialization to get working exceptions and
sys.stderr earlier. Changes:
set earlier to get an usable sys.stderr ealier.
function.
and new_interpreter() to get working exceptions earlier.
pycore_init_xxx() functions
it from _Py_InitializeCore().
_PyInitError rather than calling Py_FatalError().
private.
https://bugs.python.org/issue35713