gh-117431: Adapt bytes and bytearray .find() and friends to Argument Clinic #117502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…section will fill in the needed info
…'the bytes' and 'the bytearray' in docstring
erlend-aasland
changed the title
Contributor
Author
|
Note that the diff is not as frightening as GitHub wants it; subtract the generated files, and the diff is within ~200 lines of code, most of it being clinic input blocks.
|
Contributor
Author
|
@methane, I intend to merge this in time for the beta in May. Aiming to land it next week. |
methane
reviewed
Apr 12, 2024
Member
methane
left a comment
methane
left a comment
There was a problem hiding this comment.
Although old docstring used [start,end], I want to fix them to [start:end].
Co-authored-by: Inada Naoki <[email protected]>
Contributor
Author
|
Thanks for the review, Inada-san! |
Co-authored-by: Inada Naoki <[email protected]>
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…ument Clinic (python#117502) This change gives a significant speedup, as the METH_FASTCALL calling convention is now used. The following bytes and bytearray methods are adapted: - count() - find() - index() - rfind() - rindex() Co-authored-by: Inada Naoki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change gives a significant speedup, as the METH_FASTCALL calling convention is used.