gh-117642: Fix PEP 737 implementation #117643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix implementation of %#T and %#N (they were implemented as %T# and %N#). * Restore tests removed in pythongh-111696.
vstinner
approved these changes
Apr 8, 2024
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. You're right, the correct formats are %#T and %#N!
| check_format('\U0001f4bb+' if sizeof(c_wchar) > 2 else '\U0001f4bb', | ||
| b'%.2lV', None, c_wchar_p('\U0001f4bb+\U0001f40d')) | ||
|
|
||
| # test %T |
Member
There was a problem hiding this comment.
Oh wait, I wrote tests, but it seems like I removed them in commit a557478 !?
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
* Fix implementation of %#T and %#N (they were implemented as %T# and %N#). * Restore tests removed in pythongh-116417.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--117643.org.readthedocs.build/