gh-117688: Fix deadlock in test_no_stale_references with GIL disabled #117720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Oh, I will take a look at it by tomorrow :) I need to read the details. |
Contributor
Author
|
Thanks! |
corona10
approved these changes
Apr 13, 2024
Member
corona10
left a comment
corona10
left a comment
There was a problem hiding this comment.
LGTM,
It is a complicated situation, and I can not find a better solution.
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…sabled (python#117720) Check `my_object_collected.wait()` in a loop to give the main thread a chance to merge the reference count fields. Additionally, call `my_object_collected.set()` in a background thread to avoid deadlocking when the destructor is called asynchronously via the eval breaker within the body of of `my_object_collected.wait()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check
my_object_collected.wait()in a loop to give the main thread achance to merge the reference count fields. Additionally, call
my_object_collected.set()in a background thread to avoid deadlockingwhen the destructor is called asynchronously via the eval breaker
within the body of of
my_object_collected.wait().ThreadPoolExecutorTest.test_no_stale_referencesmay hang with GIL disabled #117688