gh-116935: Document that heap types need to support garbage collection #118021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bedevere-app
bot
added
docs
kalebers
approved these changes
Apr 18, 2024
Member
|
Thank you for the addition! |
Merged
JelleZijlstra
approved these changes
Apr 19, 2024
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
The wording looks good but I'd like another review from someone who is more familiar with the C API.
kalebers
approved these changes
Apr 19, 2024
kalebers
left a comment
kalebers
left a comment
There was a problem hiding this comment.
Well done, thanks for adding helpful information!
encukou
reviewed
Apr 19, 2024
encukou
approved these changes
Apr 19, 2024
|
Thanks @savannahostrowski for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 19, 2024
…lection (pythonGH-118021) (cherry picked from commit 5d54436) Co-authored-by: Savannah Ostrowski <[email protected]>
|
GH-118092 is a backport of this pull request to the 3.12 branch. |
Member
Author
|
Thanks for the reviews, folks! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--118021.org.readthedocs.build/
Fixes: #116935