Skip to content

Conversation

@colesbury
Copy link
Contributor

@colesbury colesbury commented Apr 25, 2024

Switch GIL to disabled by default in free-threaded build so that the free-threaded CIs catch thread-safety issues.

Switch GIL to disabled by default in free-threaded build so that the
free-threaded CIs catch thread-safety issues.
@colesbury
Copy link
Contributor Author

!buildbot nogil

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @colesbury for commit 9fc88f4 🤖

The command will test the builders whose names match following regular expression: nogil

The builders matched are:

  • x86-64 MacOS Intel ASAN NoGIL PR
  • AMD64 Ubuntu NoGIL Refleaks PR
  • ARM64 MacOS M1 NoGIL PR
  • AMD64 Windows Server 2022 NoGIL PR
  • AMD64 Ubuntu NoGIL PR
  • ARM64 MacOS M1 Refleaks NoGIL PR
  • x86-64 MacOS Intel NoGIL PR

@colesbury colesbury requested review from DinoV and swtaarrs April 26, 2024 15:04
@colesbury colesbury marked this pull request as ready for review April 26, 2024 15:04
Copy link
Contributor

@SonicField SonicField left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@DinoV DinoV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!!

Copy link
Member

@swtaarrs swtaarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exciting 😃

@colesbury colesbury merged commit 5a90de0 into python:main Apr 26, 2024
@colesbury colesbury deleted the gh-116749-disable-gil branch April 26, 2024 18:22
@corona10
Copy link
Member

Historical moment!

@cychen2021
Copy link

Cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants