gh-117549: Don't use designated initializers in headers #118580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scoder
approved these changes
May 4, 2024
Contributor
scoder
left a comment
scoder
left a comment
There was a problem hiding this comment.
The change looks reasonable to me and should resolve the issue. I couldn't test it because so far I found the problem only with MSVC and I don't have MSVC to test locally. Compiling CPython main with this patch on Linux with g++ and testing it there worked ok for me. Regarding performance, any C/C++ compiler that fails to alias the inlined function call and its return value into a plain value here should blush and rub its face in dirt.
Contributor
|
Thanks for the quick response, I appreciate it. |
Member
Author
|
Benchmarks show nothing unexpected. I'll merge now. |
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
…#118580) The designated initializer syntax in static inline functions in pycore_backoff.h causes problems for C++ or MSVC users who aren't yet using C++20. While internal, pycore_backoff.h is included (indirectly, via pycore_code.h) by some key 3rd party software that does so for speed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently in C++ this requires a recent standard version (C++20) and not everyone can switch to that yet. And this header, while internal, is included (possibly indirectly, via pycore_code.h) by some key 3rd party software that does so for speed, and we don't want to require folks to upgrade their C++ standard version when upgrading to Python 3.13.
NOTE: Before merging this I want to double-check that it doesn't slow things down. I'll start a benchmark run on our internal benchmark infrastructure.