Skip to content

Conversation

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 5, 2024

(cherry picked from commit b6f0ab5)

Co-authored-by: Ryan Batchelder [email protected]

(cherry picked from commit b6f0ab5)

Co-authored-by: Ryan Batchelder <[email protected]>
@jaraco
Copy link
Member

jaraco commented Aug 6, 2024

Since there was no objection from @Yhg1s, I'll make the executive decision to merge it. I'll be happy to revert it if requested.

@jaraco jaraco merged commit 7063665 into python:3.12 Aug 6, 2024
@jaraco jaraco removed the request for review from a team August 6, 2024 14:05
@Yhg1s
Copy link
Member

Yhg1s commented Aug 6, 2024

I can't object to a PR that wasn't brought to my attention, can I? :)

I don't actually think this is a good idea for 3.12, but I don't think it matters enough to revert the commit.

@jaraco
Copy link
Member

jaraco commented Aug 6, 2024

I can't object to a PR that wasn't brought to my attention, can I? :)

I noticed that, but assumed (perhaps incorrectly) that tagging you on the parent issue was adequate notice. I could have been more careful about the notices.

I don't actually think this is a good idea for 3.12, but I don't think it matters enough to revert the commit.

It wasn't my intention to bully. Just say the word and I'll enact the revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants