Skip to content

[3.5] bpo-34656: Avoid relying on signed overflow in _pickle memos (GH-9261) #11869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larryhastings merged 3 commits into from
Feb 26, 2019
Merged

[3.5] bpo-34656: Avoid relying on signed overflow in _pickle memos (GH-9261) #11869

larryhastings merged 3 commits into from
Feb 26, 2019

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Feb 15, 2019 •
edited by bedevere-bot
Loading

(cherry picked from commit a4ae828)

https://bugs.python.org/issue34656

@vstinner
Copy link
Member Author

vstinner commented Feb 15, 2019 •
edited by bedevere-bot
Loading

Oh, FTP tests are failing on Travis CI :-( I should backport this fix:

commit c11b3b19a5b022c6c229043d37f9a9fd06f22500
Author: Victor Stinner <[email protected]>
Date:   Wed Dec 5 01:58:31 2018 +0100

    [bpo-35411](https://bugs.python.org/issue35411): Skip test_urllib2net FTP tests on Travis CI (GH-10907)
    
    On Travis CI, FTP tests of test_urllib2net randomly fail with "425
    Security: Bad IP connecting".
    
    test.pythoninfo now also logs TRAVIS environment variable.

@vstinner
Copy link
Member Author

vstinner commented Feb 15, 2019

Oh, FTP tests are failing on Travis CI :-( I should backport this fix:

Done: I created PR #11874.

@vstinner vstinner mentioned this pull request Feb 15, 2019
Merged
@vstinner
Copy link
Member Author

vstinner commented Feb 25, 2019

@larryhastings "ftplib.error_temp: 425 Security: Bad IP connecting." bites again, you need a new merge to get my FTP fix.

@bedevere-bot
Copy link

bedevere-bot commented Feb 26, 2019

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!

@larryhastings
Copy link
Contributor

larryhastings commented Feb 26, 2019

Thanks for the backported fix! It does my heart good to see pickle avoiding integer overflows.

@larryhastings larryhastings merged commit ef33dd6 into python:3.5 Feb 26, 2019
@vstinner vstinner deleted the pickle_load35 branch April 29, 2019 14:00
@httpsgithubcomxcainiao httpsgithubcomxcainiao mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vstinner @bedevere-bot @larryhastings @gpshead @the-knights-who-say-ni @benjaminp