gh-65454: avoid triggering call to a PropertyMock in NonCallableMock.__setattr__ #120019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjw296
approved these changes
Jun 8, 2024
Contributor
cjw296
left a comment
cjw296
left a comment
There was a problem hiding this comment.
LGTM. Do you consider this a bugfix or a feature improvement?
Contributor
Author
Thanks. I believe this is a bug (it was filed as one) since it should be expected that a |
cjw296
added
needs backport to 3.12
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 11, 2024
…eMock.__setattr__ (pythonGH-120019) (cherry picked from commit 9e9ee50) Co-authored-by: blhsing <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jun 11, 2024
…eMock.__setattr__ (pythonGH-120019) (cherry picked from commit 9e9ee50) Co-authored-by: blhsing <[email protected]>
|
GH-120336 is a backport of this pull request to the 3.13 branch. |
|
GH-120337 is a backport of this pull request to the 3.12 branch. |
mrahtz
pushed a commit
to mrahtz/cpython
that referenced
this pull request
Jun 30, 2024
…eMock.__setattr__ (python#120019)
noahbkim
pushed a commit
to hudson-trading/cpython
that referenced
this pull request
Jul 11, 2024
…eMock.__setattr__ (python#120019)
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…eMock.__setattr__ (python#120019)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid triggering call to a
PropertyMockinNonCallableMock.__setattr__Previously attaching a
PropertyMockto a mock object would trigger a call to the property mock due to a recursive__setattr__call.This is now fixed by setting the given property mock as an attribute of the hosting mock directly in its
__dict__instead.