Skip to content

[2.7] bpo-36019: Use pythontest.net instead of example.com in network tests (GH-11941) #12177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 4 commits into from
Mar 5, 2019
Merged

[2.7] bpo-36019: Use pythontest.net instead of example.com in network tests (GH-11941) #12177

vstinner merged 4 commits into from
Mar 5, 2019

Conversation

@matrixise
Copy link
Member

@matrixise matrixise commented Mar 5, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Mar 5, 2019
@matrixise matrixise changed the title [2.7]: bpo-36019: Use pythontest.net instead of example.com in network tests (GH-11941) [2.7] bpo-36019: Use pythontest.net instead of example.com in network tests (GH-11941) Mar 5, 2019
vstinner
vstinner requested changes Mar 5, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_urllib2net.py: More tests still use "http://www.example.com/":

  • CloseSocketTest.test_close()
  • test_fileno() and test_custom_headers() of OtherNetworkTests.
  • TimeoutTest

@bedevere-bot
Copy link

bedevere-bot commented Mar 5, 2019

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@matrixise
Copy link
Member Author

matrixise commented Mar 5, 2019

I have made the requested changes; please review again

@bedevere-bot
Copy link

bedevere-bot commented Mar 5, 2019

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

vstinner
vstinner approved these changes Mar 5, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I blocked access to example.com from my laptop using:
#11941 (review)

Without the test, test_urllib2net fails. With the change, test_urllib2net pass. Command "./python -m test -u all test_urllib2net".

I also ran "./python -m test -j0 -u all -r" with the change: SUCCESS.

@vstinner vstinner merged commit 84772e0 into python:2.7 Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@matrixise @bedevere-bot @vstinner @the-knights-who-say-ni