gh-121860: Fix crash when materializing managed dict #121866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The object's inline values may be marked invalid if the materialized dict was already initialized and then deleted.
pablogsal
reviewed
Jul 16, 2024
Member
|
Confirmed that fixes Cython as well: #121860 (comment) |
pablogsal
approved these changes
Jul 16, 2024
Member
pablogsal
left a comment
pablogsal
left a comment
There was a problem hiding this comment.
LGTM
Confirmed it fixes the original issue and the Cython test
|
Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 16, 2024
…121866) The object's inline values may be marked invalid if the materialized dict was already initialized and then deleted. (cherry picked from commit 162b41f) Co-authored-by: Sam Gross <[email protected]>
|
GH-121867 is a backport of this pull request to the 3.13 branch. |
colesbury
added a commit
that referenced
this pull request
Jul 16, 2024
… (#121867) The object's inline values may be marked invalid if the materialized dict was already initialized and then deleted. (cherry picked from commit 162b41f) Co-authored-by: Sam Gross <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The object's inline values may be marked invalid if the materialized dict was already initialized and then deleted.