bpo-36239: Skip comments in gettext infos #12255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
approved these changes
Mar 19, 2019
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, but IMHO the change deserves a few more comments :-)
JulienPalard
force-pushed
the
gettext-comments
branch
from
efeee18 to
43ed3ee
Compare
JulienPalard
force-pushed
the
gettext-comments
branch
from
43ed3ee to
b28003b
Compare
Contributor
|
Thanks @JulienPalard for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 9, 2019
(cherry picked from commit afd1e6d) Co-authored-by: Julien Palard <[email protected]>
|
GH-13218 is a backport of this pull request to the 3.7 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue36239