gh-124285: Fix bug where bool() is called multiple times for the same part of a boolean expression

[iritkatriel]

Fixes #124285.

• Issue: Behavior change for foo and 1 or 2: 3.12 newly converts foo to bool twice #124285

---

📚 Documentation preview 📚: https://cpython-previews--124394.org.readthedocs.build/

[markshannon]

Very nice.
One suggestion for a comment, otherwise lgtm.

[JelleZijlstra]

@ncoghlan on the issue suggested we could do this in the AST optimizer without changing the eval loop. Is that approach worth considering? It would involve transforming a and b or c into (b or c) if a else c.

[iritkatriel]

@ncoghlan on the issue suggested we could do this in the AST optimizer without changing the eval loop. Is that approach worth considering? It would involve transforming a and b or c into (b or c) if a else c.

I'm not sure I see what the general solution is, but I'm all for trying it.

[iritkatriel]

I'll merge this though - we can easily replace this with the alternative idea. The "sequence" pseudo-ops change is worth having anyway.