[2.7] bpo-29960 _random.Random corrupted on exception in setstate(). … #1289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@serhiy-storchaka Can you please check if I backported this correctly? There was a conflict in _randommodule.c which I have to resolve manually. Just making sure if everything is still in order. |
serhiy-storchaka
requested changes
Apr 26, 2017
Modules/_randommodule.c
Outdated
Member
There was a problem hiding this comment.
uint32_t is C99. Use unsigned long instead.
Member
Author
There was a problem hiding this comment.
Thanks, changed to unsigned long.
Modules/_randommodule.c
Outdated
Member
There was a problem hiding this comment.
Leave the 2.7 code at the right hand of assignment.
Member
|
Why you have removed the |
Member
|
@serhiy-storchaka there's an email to python-committers about it, but the label was removed from GitHub entirely so I didn't specifically remove it just for this PR. |
Mariatta
force-pushed
the
backport-9616a82-2.7
branch
from
2b9bd06 to
bd8bc50
Compare
serhiy-storchaka
approved these changes
May 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…(GH-1019).
(cherry picked from commit 9616a82)