gh-129643: Fix PyList_Insert in free-threading builds
#129680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesbury
reviewed
Feb 5, 2025
Member
Author
|
Thanks! I've spent several hours reading about relaxed and release. I was not fully aware about the differences. I learned something new :) |
kumaraditya303
approved these changes
Feb 6, 2025
Member
Author
|
I wrote a blog post about this PR and what I learned (in Russian, but tg has auto-translate): https://t.me/opensource_findings_chat/6792 |
|
Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Member
Author
|
Thanks again! |
|
Sorry, @sobolevn, I could not cleanly backport this to |
sobolevn
added a commit
to sobolevn/cpython
that referenced
this pull request
Feb 6, 2025
…ythonGH-129680) (cherry picked from commit 63f0406) Co-authored-by: sobolevn <[email protected]>
|
GH-129725 is a backport of this pull request to the 3.13 branch. |
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Feb 7, 2025
cmaloney
pushed a commit
to cmaloney/cpython
that referenced
this pull request
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing @colesbury's comment here: #129643 (comment)
PyList_SetItemmissing atomic store #129643