gh-130145: fix loop.run_forever when loop is already running
#130146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
requested review from
1st1,
asvetlov and
willingc
as code owners
kumaraditya303
added
needs backport to 3.12
Contributor
Author
|
Merging as the fix is trivial. |
|
Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 15, 2025
…ythonGH-130146) (cherry picked from commit a545749) Co-authored-by: Kumar Aditya <[email protected]>
|
Sorry, @kumaraditya303, I could not cleanly backport this to |
|
GH-130147 is a backport of this pull request to the 3.13 branch. |
kumaraditya303
added a commit
that referenced
this pull request
Feb 15, 2025
…GH-130146) (#130147) gh-130145: fix `loop.run_forever` when loop is already running (GH-130146) (cherry picked from commit a545749) Co-authored-by: Kumar Aditya <[email protected]>
Member
@kumaraditya303 https://github.com/python/cpython/blob/3.12/Lib/asyncio/base_events.py has no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.