bpo-30178: Indent methods and attributes of MimeType class #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DimitrisJim, thanks for your PR! By analyzing the history of the files in this pull request, we identified @birkenfeld, @orsenthil and @terryjreedy to be potential reviewers. |
terryjreedy
reviewed
Apr 27, 2017
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
I verified that the only change is to add multiple 3-space indents. I don't know enough about .rst standards to know if the indents are correct
Mariatta
approved these changes
May 13, 2017
Member
|
Thanks @DimitrisJim :) |
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
May 13, 2017
…honGH-1306) (cherry picked from commit c711680)
Mariatta
pushed a commit
to Mariatta/cpython
that referenced
this pull request
May 13, 2017
…honGH-1306) (cherry picked from commit c711680)
Mariatta
added a commit
that referenced
this pull request
May 13, 2017
Mariatta
added a commit
that referenced
this pull request
May 13, 2017
Mariatta
pushed a commit
that referenced
this pull request
May 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
MimeTypesclass's methods and attributes aren't indented and the resulting documentation is not indented and duplicates the class name. Proposed change just indents these.