bpo-35924: Document a workaround for a curses bug #13209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ncurses library has a bug which can provoke a segfault when a window is resized. The bug is provoked when a string with embedded newlines is added via addstr(). This commit documents that problem in the curses python library documentation and relates how to workaround the problem in the calling code. Related to https://bugs.python.org/issue35924
abadger
force-pushed
the
hint-on-curses-bug
branch
from
6285a89 to
4138f24
Compare
Contributor
Author
|
The bug has now been fixed in upstream ncurses. I think merging this documentation change would be sufficient to close the bug on our side. |
lisroach
approved these changes
May 17, 2019
Contributor
lisroach
left a comment
lisroach
left a comment
There was a problem hiding this comment.
Thanks for all the work you did for this!
Contributor
Author
|
I'm just happy to help :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ncurses library has a bug which can provoke a segfault when a window
is resized. The bug is provoked when a string with embedded newlines is
added via addstr(). This commit documents that problem in the curses
python library documentation and relates how to workaround the problem
in the calling code.
It will likely be years before every vendor upgrades their ncurses library even once upstream fixes the bug so it seems like a good idea to document the issue and a workaround.
Related to https://bugs.python.org/issue35924
Note that merging this change should not close the bug report as it only documents a workaround.
https://bugs.python.org/issue35924