Skip to content

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented May 22, 2019

CVE-2019-9948: Avoid file reading as disallowing the unnecessary URL
scheme in URLopener().open() and URLopener().retrieve()
of urllib.request.

Co-Authored-By: SH [email protected]
(cherry picked from commit 0c2b6a3)
(cherry picked from commit 34bab21)

https://bugs.python.org/issue35907

@vstinner
Copy link
Member Author

@tirkarthi: Would you mind to review this backport from 3.7 to 3.6?

…) (GH-13505)

CVE-2019-9948: Avoid file reading by disallowing local-file:// and
local_file:// URL schemes in URLopener().open() and
URLopener().retrieve() of urllib.request.

Co-Authored-By: SH <[email protected]>
(cherry picked from commit 0c2b6a3)
(cherry picked from commit 34bab21)
@vstinner
Copy link
Member Author

I updated the NEWS entry and the commit message.

Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@ned-deily ned-deily merged commit 4f06dae into python:3.6 May 29, 2019
@vstinner vstinner deleted the local_file36 branch July 15, 2019 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-security A security issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants