[3.14] gh-136912: fix handling of OverflowError in hmac.digest (GH-136917)
#137116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st` (pythonGH-136917) The OpenSSL and HACL* implementations of HMAC single-shot digest computation reject keys whose length exceeds `INT_MAX` and `UINT32_MAX` respectively. The OpenSSL implementation also rejects messages whose length exceed `INT_MAX`. Using such keys in `hmac.digest` previously raised an `OverflowError` which was propagated to the caller. This commit mitigates this case by making `hmac.digest` fall back to HMAC's pure Python implementation which accepts arbitrary large keys or messages. This change only affects the top-level entrypoint `hmac.digest`, leaving `_hashopenssl.hmac_digest` and `_hmac.compute_digest` untouched. (cherry picked from commit d658b90) Co-authored-by: Bénédikt Tran <[email protected]>
This was referenced Jul 26, 2025
gpshead
approved these changes
Jul 27, 2025
Member
|
waiting for 3.14.1 |
Member
|
@picnixz: Is it still a draft? The 3.14 branch was reopened for 3.14.1 changes. |
github-project-automation
bot
moved this from Todo
to Done
in Release and Deferred blockers 🚫
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OpenSSL and HACL* implementations of HMAC single-shot digest computation reject keys whose length exceeds
INT_MAXandUINT32_MAXrespectively. The OpenSSL implementation also rejects messages whose length exceedINT_MAX.Using such keys in
hmac.digestpreviously raised anOverflowErrorwhich was propagated to the caller. This commit mitigates this case by makinghmac.digestfall back to HMAC's pure Python implementation which accepts arbitrary large keys or messages.This change only affects the top-level entrypoint
hmac.digest, leaving_hashopenssl.hmac_digestand_hmac.compute_digestuntouched.(cherry picked from commit d658b90)