Add explanation comments for tests for overlapped ZIP entries #137152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
tests
Member
Author
|
@jaraco, are these comments fine to you? |
jaraco
approved these changes
Nov 25, 2025
Member
jaraco
left a comment
jaraco
left a comment
There was a problem hiding this comment.
These look good to me. I can't vouch for their correctness, but at first blush they look great.
I personally would have written these as docstrings (I don't love the syntax of multi-line comments), but I'm also fine with the change.
Member
Author
|
They are too long for single-line docstring, and the test output including only the first line of the dosctring will be ugly. |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2025
…GH-137152) (cherry picked from commit 100c726) Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 5, 2025
…GH-137152) (cherry picked from commit 100c726) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-142310 is a backport of this pull request to the 3.14 branch. |
|
GH-142311 is a backport of this pull request to the 3.13 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Dec 5, 2025
…H-137152) (GH-142310) (cherry picked from commit 100c726) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this pull request
Dec 5, 2025
…H-137152) (GH-142311) (cherry picked from commit 100c726) Co-authored-by: Serhiy Storchaka <[email protected]>
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.