Skip to content

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 4, 2019

@pablogsal
Copy link
Member Author

pablogsal commented Jun 4, 2019

Tested locally:

❯ ./python.exe -m test test_asyncio -m test_stream_writer_create_warning -R :
Run tests sequentially
0:00:00 load avg: 1.96 [1/1] test_asyncio
beginning 9 repetitions
123456789
.........

== Tests result: SUCCESS ==

1 test OK.

Total duration: 1 sec 975 ms
Tests result: SUCCESS

without the patch:

❯ ./python.exe -m test test_asyncio -m test_stream_writer_create_warning -R :
Run tests sequentially
0:00:00 load avg: 2.21 [1/1] test_asyncio
beginning 9 repetitions
123456789
.test test_asyncio failed -- Traceback (most recent call last):
  File "/Users/pgalindo3/github/cpython/Lib/test/test_asyncio/test_streams.py", line 1238, in test_stream_writer_create_warning
    asyncio.StreamWriter
AssertionError: DeprecationWarning not triggered

test_asyncio failed

== Tests result: FAILURE ==

1 test failed:
    test_asyncio

Total duration: 581 ms
Tests result: FAILURE

@pablogsal pablogsal requested review from ambv and vstinner June 4, 2019 10:11
@asvetlov
Copy link
Contributor

asvetlov commented Jun 4, 2019

@pablogsal there is another PR for improving streams tests stability: #13790
I'd like to merge it but waiting for review

@pablogsal
Copy link
Member Author

Thanks, @asvetlov, I will try to review it as soon as I merge this and unblock the refleaks buildbots to allow beta1 release (they are still red as of now).

@pablogsal pablogsal merged commit 4cdbc45 into python:master Jun 4, 2019
@pablogsal pablogsal deleted the bpo37148 branch June 4, 2019 10:26
@ambv
Copy link
Contributor

ambv commented Jun 4, 2019

@vstinner
Copy link
Member

vstinner commented Jun 4, 2019

@pablogsal: https://buildbot.python.org/all/#/builders/168/builds/1150

This failure is unrelated to this fix. It will be fixed by #13790 which has just been merged ;-) (but not part of this build)

@tirkarthi
Copy link
Member

tirkarthi commented Jun 4, 2019

There is a test__xxsubinterpreters in the build for #13790 : https://buildbot.python.org/all/#/builders/168/builds/1151/steps/5/logs/stdio

======================================================================
FAIL: test_still_running (test.test__xxsubinterpreters.DestroyTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/home/buildbot/python/3.x.koobs-freebsd-current/build/Lib/test/test__xxsubinterpreters.py", line 765, in test_still_running
    interpreters.destroy(interp)
AssertionError: RuntimeError not raised
----------------------------------------------------------------------
Ran 112 tests in 30.951s
FAILED (failures=1, skipped=5)
test test__xxsubinterpreters failed

Edit : Probably unrelated to the asyncio changes in the buildbot run but thought to add it here

@vstinner
Copy link
Member

vstinner commented Jun 4, 2019

@tirkarthi: Please open a new issue on bugs.python.org, this issue is unrelated.

DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants