gh-139391: properly handle signal.signal() in UnixConsole when called from a non-main thread
#139392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yihong0618 <[email protected]>
yihong0618
requested review from
ambv,
lysnikolaou and
pablogsal
as code owners
picnixz
reviewed
Sep 28, 2025
Signed-off-by: yihong0618 <[email protected]> Co-authored-by: Bénédikt Tran <[email protected]>
picnixz
reviewed
Sep 28, 2025
Co-authored-by: Bénédikt Tran <[email protected]>
picnixz
reviewed
Sep 28, 2025
picnixz
changed the title
signal.signal() in UnixConsole when called from a non-main thread
Signed-off-by: yihong0618 <[email protected]>
picnixz
reviewed
Sep 29, 2025
Misc/NEWS.d/next/Library/2025-09-28-16-34-11.gh-issue-139391.nRFnmx.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Bénédikt Tran <[email protected]>
Signed-off-by: yihong0618 <[email protected]>
picnixz
approved these changes
Sep 29, 2025
Member
|
I'll wait for @ambv to review this as well. |
Contributor
Author
Thank you very much! |
kumaraditya303
approved these changes
Oct 3, 2025
ambv
reviewed
Oct 9, 2025
Signed-off-by: yihong0618 <[email protected]>
kumaraditya303
approved these changes
Oct 9, 2025
kumaraditya303
added
topic-asyncio
topic-repl
|
Thanks @yihong0618 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
GH-139858 is a backport of this pull request to the 3.14 branch. |
|
Thanks @yihong0618 for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Sorry, @yihong0618 and @kumaraditya303, I could not cleanly backport this to |
|
GH-139861 is a backport of this pull request to the 3.13 branch. |
ambv
pushed a commit
to ambv/cpython
that referenced
this pull request
Oct 9, 2025
…sole` when called from a non-main thread (pythonGH-139392) (cherry picked from commit b8c8b8f) Co-authored-by: yihong <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 9, 2025
…hen called from a non-main thread (pythonGH-139392) (cherry picked from commit b8c8b8f) Co-authored-by: yihong <[email protected]>
kumaraditya303
pushed a commit
that referenced
this pull request
Oct 9, 2025
…when called from a non-main thread (GH-139392) (#139861) (cherry picked from commit b8c8b8f) Co-authored-by: yihong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after this patch it goes normal with ctrl+z and fg
python -m asyncioprocess is not properly handled on Unix-like platforms #139391