Skip to content

gh-133210: Fix test_pydoc without docstrings #139654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 1 commit into from
Oct 6, 2025
Merged

gh-133210: Fix test_pydoc without docstrings #139654

vstinner merged 1 commit into from
Oct 6, 2025

Conversation

@efimov-mikhail
Copy link
Member

@efimov-mikhail efimov-mikhail commented Oct 6, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Oct 6, 2025
@bedevere-app bedevere-app bot mentioned this pull request Oct 6, 2025
Closed
@efimov-mikhail efimov-mikhail changed the title gh-133210: Fix test_pydoc without docstrings gh-133210: Fix test_pydoc without docstrings Oct 6, 2025
@efimov-mikhail
Copy link
Member Author

efimov-mikhail commented Oct 6, 2025

CC @vstinner @sobolevn

vstinner
vstinner approved these changes Oct 6, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tests pass on Python built with ./configure --with-pydebug --without-doc-strings.

@vstinner vstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Oct 6, 2025
@vstinner vstinner merged commit 708de26 into python:main Oct 6, 2025
57 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 6, 2025

Thanks @efimov-mikhail for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Oct 6, 2025

Sorry, @efimov-mikhail and @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 708de26e31b65cd3ae768882c8da59284917a80d 3.14

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 6, 2025
@efimov-mikhail @miss-islington
pythongh-133210: Fix test_pydoc without docstrings (pythonGH-139654)
7c82711 
(cherry picked from commit 708de26)

Co-authored-by: Mikhail Efimov <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 6, 2025

GH-139666 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 6, 2025
@vstinner vstinner added needs backport to 3.14 bugs and security fixes and removed needs backport to 3.14 bugs and security fixes labels Oct 6, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 6, 2025

Thanks @efimov-mikhail for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Oct 6, 2025

Sorry, @efimov-mikhail and @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 708de26e31b65cd3ae768882c8da59284917a80d 3.14

@vstinner vstinner removed the needs backport to 3.14 bugs and security fixes label Oct 6, 2025
@vstinner
Copy link
Member

vstinner commented Oct 6, 2025

Ah, Python 3.14 is not affected since #139160 was not backported to 3.14 yet (it's pending).

@vstinner
Copy link
Member

vstinner commented Oct 6, 2025

Merged, thanks for the fix.

vstinner pushed a commit that referenced this pull request Oct 6, 2025
@miss-islington @efimov-mikhail
[3.13] gh-133210: Fix test_pydoc without docstrings (GH-139654) (#1…
a35e870 
…39666)

gh-133210: Fix `test_pydoc` without docstrings (GH-139654)
(cherry picked from commit 708de26)

Co-authored-by: Mikhail Efimov <[email protected]>
danigm pushed a commit to openSUSE-Python/cpython that referenced this pull request Oct 7, 2025
@efimov-mikhail @danigm
pythongh-133210: Fix test_pydoc without docstrings (python#139654)
b77532e
@vstinner vstinner added the needs backport to 3.14 bugs and security fixes label Oct 8, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Oct 8, 2025

Thanks @efimov-mikhail for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 8, 2025
@efimov-mikhail @miss-islington
pythongh-133210: Fix test_pydoc without docstrings (pythonGH-139654)
024b1a0 
(cherry picked from commit 708de26)

Co-authored-by: Mikhail Efimov <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 8, 2025

GH-139777 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Oct 8, 2025
vstinner pushed a commit that referenced this pull request Oct 8, 2025
@miss-islington @efimov-mikhail
[3.14] gh-133210: Fix test_pydoc without docstrings (GH-139654) (#1…
a96cde9 
…39777)

gh-133210: Fix `test_pydoc` without docstrings (GH-139654)
(cherry picked from commit 708de26)

Co-authored-by: Mikhail Efimov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Assignees

@vstinner vstinner

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@efimov-mikhail @vstinner @sobolevn