Skip to content

GH-139436: Remove PDF and CHM from IDLE HelpSource #140418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AA-Turner merged 1 commit into from
Dec 9, 2025
Merged

GH-139436: Remove PDF and CHM from IDLE HelpSource #140418

AA-Turner merged 1 commit into from
Dec 9, 2025

Conversation

@AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Oct 21, 2025 •
edited by bedevere-app bot
Loading

cc @terryjreedy

I also removed some other references to CHM, which we no longer support/install.

A

@bedevere-app bedevere-app bot mentioned this pull request Oct 21, 2025
Open
@AA-Turner AA-Turner mentioned this pull request Nov 17, 2025
Draft
gpshead added a commit to gpshead/cpython that referenced this pull request Nov 17, 2025
@gpshead @claude
Adopt additional IDLE help file changes from python#140418
13d562e 
Remove PDF and CHM references from IDLE help file browser and config.

Co-Authored-By: Claude <[email protected]>
@AA-Turner AA-Turner merged commit c5825ff into python:main Dec 9, 2025
51 checks passed
@AA-Turner AA-Turner deleted the idlelib-help-docs branch December 9, 2025 12:33
@terryjreedy
Copy link
Member

terryjreedy commented Dec 10, 2025

Is this correct? -- while the .pdf removal (1 line of the diff) was backported, the .chm removal was not, so that this should not backported?

@AA-Turner
Copy link
Member Author

AA-Turner commented Dec 10, 2025

@terryjreedy I'm not sure I follow, sorry. I'm on mobile and don't have the issue to hand, sorry, but I understand that we stopped bundling CHM years ago? I don't think it's included on any supported branch, from memory.

A

@terryjreedy terryjreedy added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Dec 11, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 11, 2025

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Dec 11, 2025

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2025
@AA-Turner @miss-islington
pythonGH-139436: Remove PDF and CHM from IDLE HelpSource (pythonGH-14…
fd32987 
…0418)

(cherry picked from commit c5825ff)

Co-authored-by: Adam Turner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 11, 2025
@AA-Turner @miss-islington
pythonGH-139436: Remove PDF and CHM from IDLE HelpSource (pythonGH-14…
0ccf303 
…0418)

(cherry picked from commit c5825ff)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Dec 11, 2025

GH-142551 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 11, 2025
@bedevere-app
Copy link

bedevere-app bot commented Dec 11, 2025

GH-142552 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 11, 2025
@terryjreedy
Copy link
Member

terryjreedy commented Dec 11, 2025

I checked my 3.13 and 3.14 installed IDLE (Windows) and F1 for each opens the local html python doc index in installdir/html. So I am sure that backport is right. Will set to automerge.

terryjreedy pushed a commit that referenced this pull request Dec 11, 2025
@miss-islington @AA-Turner
[3.13] GH-139436: Remove PDF and CHM from IDLE HelpSource (GH-140418) (…
813bcff 
…#142551)

GH-139436: Remove PDF and CHM from IDLE HelpSource (GH-140418)
(cherry picked from commit c5825ff)

Co-authored-by: Adam Turner <[email protected]>
terryjreedy pushed a commit that referenced this pull request Dec 11, 2025
@miss-islington @AA-Turner
[3.14] GH-139436: Remove PDF and CHM from IDLE HelpSource (GH-140418) (…
82ebdd2 
…#142552)

GH-139436: Remove PDF and CHM from IDLE HelpSource (GH-140418)
(cherry picked from commit c5825ff)

Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AA-Turner @terryjreedy @hugovk