Add missing NEWS entry for gh-140517 #140560
Conversation
| @@ -0,0 +1,4 @@ | |||
| Fixed a refcount leak when iterating over the result of the | |||
| built-in ``map`` function. It was possible if input ``iterables`` | |||
| have different lengths and ``strict`` is ``True``. | |||
There was a problem hiding this comment.
Maybe 'and strict mode is on'?
There was a problem hiding this comment.
Or strict=True.
Or maybe rewrite the entry as:
Fixed a reference leak when iterating over the result of :func:`map` with ``strict=True`` when the input iterables have different lengths.
Misc/NEWS.d/next/Core_and_Builtins/2025-10-24-20-16-42.gh-issue-140517.cqun-K.rst
Outdated
Show resolved
Hide resolved
…e-140517.cqun-K.rst Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Looks good to me. Will leave it open for a little bit in case Serhyi has feedback.
serhiy-storchaka
changed the title
| @@ -0,0 +1,4 @@ | |||
| Fixed a reference leak when iterating over the result of | |||
| :func:`map`. The leak could happen when input ``iterables`` | |||
There was a problem hiding this comment.
I think that *iterables* or without hightlighting would be better.
| @@ -0,0 +1,4 @@ | |||
| Fixed a refcount leak when iterating over the result of the | |||
| built-in ``map`` function. It was possible if input ``iterables`` | |||
| have different lengths and ``strict`` is ``True``. | |||
There was a problem hiding this comment.
Or strict=True.
Or maybe rewrite the entry as:
Fixed a reference leak when iterating over the result of :func:`map` with ``strict=True`` when the input iterables have different lengths.
|
IMO, this suits better: |
|
Thanks @efimov-mikhail for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
(cherry picked from commit d78d7a5) Co-authored-by: Mikhail Efimov <[email protected]>
|
GH-140565 is a backport of this pull request to the 3.14 branch. |
(cherry picked from commit d78d7a5) Co-authored-by: Mikhail Efimov <[email protected]>
4 participants
map_nextin strict mode in case of error #140517