Skip to content

GH-100964: Fix reference cycle in exhausted generator frames #141112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
savannahostrowski merged 6 commits into from
Dec 17, 2025
Merged

GH-100964: Fix reference cycle in exhausted generator frames #141112

savannahostrowski merged 6 commits into from
Dec 17, 2025
+14 −1

Conversation

@savannahostrowski
Copy link
Member

@savannahostrowski savannahostrowski commented Nov 6, 2025 •
edited
Loading

So after spelunking here it appears that the issue here is that we can't clear frame->previous after _PyFrame_ClearExceptCode in clear_gen_frame because _PyFrame_ClearExceptCode calls take_ownership which copies the frame with a stale previous pointer. This makes f_back point to the caller, instead of None.

@savannahostrowski savannahostrowski added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Nov 6, 2025
@bedevere-app bedevere-app bot mentioned this pull request Nov 6, 2025
Closed
@savannahostrowski
Copy link
Member Author

savannahostrowski commented Dec 1, 2025

@markshannon Are you still the right person to take a look at this 😄 ?

@savannahostrowski savannahostrowski deleted the reference-cycle branch December 4, 2025 22:59
@savannahostrowski savannahostrowski restored the reference-cycle branch December 4, 2025 22:59
@kumaraditya303
Copy link
Contributor

kumaraditya303 commented Dec 17, 2025

I came across this bug today while writing an asyncio test and this fixed it.

ping @markshannon for review

markshannon
markshannon approved these changes Dec 17, 2025
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix

@savannahostrowski savannahostrowski enabled auto-merge (squash) December 17, 2025 18:52
@savannahostrowski savannahostrowski merged commit 92243dc into python:main Dec 17, 2025
52 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 17, 2025

Thanks @savannahostrowski for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 17, 2025
@savannahostrowski @miss-islington
pythonGH-100964: Fix reference cycle in exhausted generator frames (p…
acc0640 
…ythonGH-141112)

(cherry picked from commit 92243dc62ce10715ab0d9074b23dea5a1bfa9dcc)

Co-authored-by: Savannah Ostrowski <[email protected]>
@miss-islington-app
Copy link

miss-islington-app bot commented Dec 17, 2025

Sorry, @savannahostrowski, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 92243dc62ce10715ab0d9074b23dea5a1bfa9dcc 3.13

@bedevere-app
Copy link

bedevere-app bot commented Dec 17, 2025

GH-142902 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Dec 17, 2025
savannahostrowski added a commit that referenced this pull request Dec 17, 2025
@miss-islington @savannahostrowski
[3.14] GH-100964: Fix reference cycle in exhausted generator frames (G…
7134b40 
…H-141112) (#142902)

GH-100964: Fix reference cycle in exhausted generator frames (GH-141112)
(cherry picked from commit 92243dc)

Co-authored-by: Savannah Ostrowski <[email protected]>
savannahostrowski added a commit that referenced this pull request Dec 17, 2025
@savannahostrowski
[3.13] GH-100964: Fix reference cycle in exhausted generator frames (…
8f7c4f1 
…G… (#142904)

* [3.13] GH-100964: Fix reference cycle in exhausted generator frames (GH-141112)
(cherry picked from commit 92243dc)

Co-authored-by: Savannah Ostrowski <[email protected]>
@kumaraditya303 kumaraditya303 removed the needs backport to 3.13 bugs and security fixes label Dec 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

@savannahostrowski savannahostrowski

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@savannahostrowski @kumaraditya303 @markshannon