-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-142419: Add mmap.set_name method for user custom annotation #142480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Misc/NEWS.d/next/Library/2025-12-10-02-31-43.gh-issue-142419.C8_LES.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
|
@picnixz: What do you think of not adding |
|
Personally, I think we should at least indicate Is it because you're worried about the allowed length? or something else? |
I still prefer to keep the current convention as much as possible. As Bénédikt mentioned, having a common prefix is important for filtering. Regarding using different conventions for CPython-defined versus user-defined mappings, I would prefer not to introduce additional distinctions that people need to learn or interpret. Keeping things simple and consistent feels more important here. For that reason, my preference is to maintain the same convention across the board. If there is no strong objection with this, I hope that I can merge this PR soon. |
vstinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
|
Ok, let's add the |
Co-authored-by: Victor Stinner <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Report error to the caller
|
@picnixz I think that we are ready to land this feature :) |
📚 Documentation preview 📚: https://cpython-previews--142480.org.readthedocs.build/