Skip to content

Conversation

@cocolato
Copy link
Contributor

@cocolato cocolato commented Dec 18, 2025

@Fidget-Spinner
Copy link
Member

@cocolato in the future could you please check on the issue before opening a PR? I already assigned this to someone else. I wont close this PR but please keep that in mind in the future. Otherwise it makes things hard to coordinate.

@cocolato
Copy link
Contributor Author

@cocolato in the future could you please check on the issue before opening a PR? I already assigned this to someone else. I wont close this PR but please keep that in mind in the future. Otherwise it makes things hard to coordinate.

Sorry about that. I'll close this PR and find other unassigned tasks to work on.

@cocolato cocolato closed this Dec 18, 2025
@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Dec 18, 2025

@cocolato no problem. Would you like to work on _UNPACK_SEQUENCE and _UNPACK_SEQUENCE_LIST? I can assign those to you. From this PR, it looks like you're a very capable contributor :).

@cocolato
Copy link
Contributor Author

@cocolato no problem. Would you like to work on _UNPACK_SEQUENCE and _UNPACK_SEQUENCE_LIST? I can assign those to you. From this PR, it looks like you're a very capable contributor :).

Thank you for your reply. I'm pleased to work on this!

@Fidget-Spinner
Copy link
Member

Fidget-Spinner commented Dec 18, 2025

@cocolato, thanks for taking them up! I will also assign you _UNPACK_SEQUENCE_TUPLE, as it's very much the same thing.

@Fidget-Spinner
Copy link
Member

@cocolato I realised unpack_sequence might cause stack overflow, so I need to discuss with Mark how to handle that.

In the meantime, this PR LGTM. I will merge it. Thanks for your contribution!

@Fidget-Spinner Fidget-Spinner merged commit 33d94ab into python:main Dec 18, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants