-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
GH-142513: Reimplement executor management #142931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… not cause arbitrary code to run
Fidget-Spinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I've given this a quite thorough review. I thought about if it's possible for executors to be ressurected such that their refcnt != 0 anymore, but I don't see how that's possible considering executors are never reused.
|
Some very strange connection things happening with git at the moment. |
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit be95cb0 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F142931%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
|
@markshannon all the refleak buildbots don't run JIT precisely because the current refleak tests can't account for an executor being created in the midst of execution :) If you want to get refleak + JIT working, you'd need to fix |
|
The sole buildbot failure seems unrelated to this PR. |
* Invalidating an executor does not cause arbitrary code to run * Executors are only freed at safe points
Enforces the following two invariants: