-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
bpo-30262: Don't expose sqlite Cache and Statement #1440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-30262: Don't expose sqlite Cache and Statement #1440
Conversation
|
@palaviv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Yhg1s, @benjaminp and @loewis to be potential reviewers. |
|
Hi @palaviv Would you be interested to upgrade your PR to the last master? Thank you |
berkerpeksag
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@palaviv if you port the NEWS entry to blurb, and add a note to Doc/whatsnew/3.8.rst, I can merge this PR. Thank you!
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
a89836b to
a114789
Compare
|
Done @berkerpeksag. I am happy to see that there is a new interest in the sqlite3 module :) |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @berkerpeksag: please review the changes made to this pull request. |
|
Thank you! @palaviv your pull requests have been on my TODO list, but unfortunately I've been pretty busy with life lately. Sorry for my late response times! |
|
Thank you @berkerpeksag. I saw you took charge on the sqlite3 module. I am very familiar with the code there and would love to help if needed. |
https://bugs.python.org/issue30262