Skip to content

Conversation

@palaviv
Copy link
Contributor

@palaviv palaviv commented May 3, 2017

@mention-bot
Copy link

@palaviv, thanks for your PR! By analyzing the history of the files in this pull request, we identified @Yhg1s, @benjaminp and @loewis to be potential reviewers.

@matrixise matrixise changed the title bpo-30262: Don't expose sqlite Cache and Statement bpo-30262: Don't expose sqlite Cache and Statement May 7, 2019
@matrixise
Copy link
Member

Hi @palaviv

Would you be interested to upgrade your PR to the last master?

Thank you

@matrixise matrixise requested a review from berkerpeksag May 7, 2019 20:48
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@palaviv if you port the NEWS entry to blurb, and add a note to Doc/whatsnew/3.8.rst, I can merge this PR. Thank you!

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@palaviv palaviv force-pushed the dont-export-sqlite-cache-and-statement branch from a89836b to a114789 Compare May 9, 2019 09:43
@palaviv
Copy link
Contributor Author

palaviv commented May 9, 2019

Done @berkerpeksag. I am happy to see that there is a new interest in the sqlite3 module :)

@palaviv
Copy link
Contributor Author

palaviv commented May 9, 2019

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@berkerpeksag: please review the changes made to this pull request.

@berkerpeksag
Copy link
Member

Thank you!

@palaviv your pull requests have been on my TODO list, but unfortunately I've been pretty busy with life lately. Sorry for my late response times!

@palaviv
Copy link
Contributor Author

palaviv commented May 9, 2019

Thank you @berkerpeksag. I saw you took charge on the sqlite3 module. I am very familiar with the code there and would love to help if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants