Skip to content

bpo-27452: IDLE: Cleanup config.py code #14577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
terryjreedy merged 2 commits into from
Jul 16, 2019
Merged

bpo-27452: IDLE: Cleanup config.py code #14577

terryjreedy merged 2 commits into from
Jul 16, 2019

Conversation

@csabella
Copy link
Contributor

@csabella csabella commented Jul 3, 2019 •
edited by bedevere-bot
Loading

  • Remove RemoveFile method.
  • Simplify CreateConfigHandlers handling of __file__.

Patch by Terry Reedy.

https://bugs.python.org/issue27452

@csabella csabella requested a review from terryjreedy as a code owner July 3, 2019 22:45
@brettcannon brettcannon added the type-feature A feature request or enhancement label Jul 5, 2019
terryjreedy
terryjreedy approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested running config.py from repository idlelib with both ../../python config.py and -m config.

@terryjreedy terryjreedy merged commit f8d4cc7 into python:master Jul 16, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Jul 16, 2019

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 16, 2019

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented Jul 16, 2019

I'm having trouble backporting to 3.7. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.7 label.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2019
@csabella @miss-islington
bpo-27452: IDLE: Cleanup config.py code (pythonGH-14577)
86c9591 
(cherry picked from commit f8d4cc7)

Co-authored-by: Cheryl Sabella <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Jul 16, 2019

GH-14802 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

miss-islington commented Jul 16, 2019

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 16, 2019
@csabella @miss-islington
bpo-27452: IDLE: Cleanup config.py code (pythonGH-14577)
c12f6f1 
(cherry picked from commit f8d4cc7)

Co-authored-by: Cheryl Sabella <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Jul 16, 2019

GH-14803 is a backport of this pull request to the 3.7 branch.

terryjreedy pushed a commit that referenced this pull request Jul 16, 2019
@miss-islington @csabella @terryjreedy
bpo-27452: IDLE: Cleanup config.py code (GH-14577) (GH-14802)
178f09f 
(cherry picked from commit f8d4cc7)

Co-authored-by: Cheryl Sabella <[email protected]>
terryjreedy pushed a commit that referenced this pull request Jul 16, 2019
@miss-islington @csabella @terryjreedy
bpo-27452: IDLE: Cleanup config.py code (GH-14577) (GH-14803)
efd23a1 
(cherry picked from commit f8d4cc7)

Co-authored-by: Cheryl Sabella <[email protected]>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@csabella @lisroach
bpo-27452: IDLE: Cleanup config.py code (pythonGH-14577)
ac00f4d
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@csabella @DinoV
bpo-27452: IDLE: Cleanup config.py code (pythonGH-14577)
72905ce
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@csabella @websurfer5
bpo-27452: IDLE: Cleanup config.py code (pythonGH-14577)
bb09b05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@csabella @miss-islington @bedevere-bot @terryjreedy @brettcannon @the-knights-who-say-ni