Skip to content

[3.5] bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) (GH-13814) #14772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
larryhastings merged 2 commits into from
Sep 7, 2019
Merged

[3.5] bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) (GH-13814) #14772

larryhastings merged 2 commits into from
Sep 7, 2019

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jul 14, 2019 •
edited by bedevere-bot
Loading

(cherry picked from commit 8d0ef0b)

Co-authored-by: Steve Dower [email protected]
(cherry picked from commit fd1771d)

https://bugs.python.org/issue36742

@miss-islington @zooba @vstinner
bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812)…
5e3ced9 
… (GH-13814)

(cherry picked from commit 8d0ef0b)

Co-authored-by: Steve Dower <[email protected]>
(cherry picked from commit fd1771d)
@vstinner vstinner changed the title bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) (GH-13814) [3.5] bpo-36742: Corrects fix to handle decomposition in usernames (GH-13812) (GH-13814) Jul 14, 2019
@vstinner vstinner removed the type-security A security issue label Jul 14, 2019
@vstinner
Copy link
Member Author

vstinner commented Jul 14, 2019

https://bugs.python.org/issue36742 is not fully fixed in the 3.5 branch: commit 4655d57 wasn't enough. We also need this second fix which is a backport from Python 3.6.

@vstinner vstinner requested a review from zooba July 14, 2019 09:56
@larryhastings
Copy link
Contributor

larryhastings commented Jul 14, 2019

Just to confirm: this PR doesn't change any code in the standard library. It only changes tests. That's what you wanted?

@vstinner
Copy link
Member Author

vstinner commented Jul 14, 2019

It changes the urllib module. I backported the change, I didn't make any change.

@larryhastings larryhastings merged commit 095373c into python:3.5 Sep 7, 2019
@bedevere-bot
Copy link

bedevere-bot commented Sep 7, 2019

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!

@larryhastings
Copy link
Contributor

larryhastings commented Sep 7, 2019

Thanks for the 3.5 backport love!

@vstinner vstinner deleted the urlnorm35 branch January 30, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba Awaiting requested review from zooba

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner @larryhastings @bedevere-bot @the-knights-who-say-ni @miss-islington