Skip to content

Conversation

@ilevkivskyi
Copy link
Member

@ilevkivskyi ilevkivskyi commented Aug 22, 2019

This adds a regression test for the issue found in the Python 2 backport, see python/typing#656

https://bugs.python.org/issue28556

Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@miss-islington
Copy link
Contributor

Thanks @ilevkivskyi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

I'm having trouble backporting to 3.8. Reason: 'Error 110 while writing to socket. Connection timed out.'. Please retry by removing and re-adding the needs backport to 3.8 label.

@miss-islington
Copy link
Contributor

Thanks @ilevkivskyi for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-15398 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 22, 2019
This adds a regression test for the issue found in the Python 2 backport, see python/typing#656

https://bugs.python.org/issue28556
(cherry picked from commit 8889627)

Co-authored-by: Ivan Levkivskyi <[email protected]>
@ilevkivskyi ilevkivskyi deleted the add-typing-tests branch August 22, 2019 17:52
miss-islington added a commit that referenced this pull request Aug 22, 2019
This adds a regression test for the issue found in the Python 2 backport, see python/typing#656

https://bugs.python.org/issue28556
(cherry picked from commit 8889627)

Co-authored-by: Ivan Levkivskyi <[email protected]>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
This adds a regression test for the issue found in the Python 2 backport, see python/typing#656


https://bugs.python.org/issue28556
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
This adds a regression test for the issue found in the Python 2 backport, see python/typing#656


https://bugs.python.org/issue28556
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
This adds a regression test for the issue found in the Python 2 backport, see python/typing#656


https://bugs.python.org/issue28556
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants