Skip to content

Conversation

@maxking
Copy link
Contributor

@maxking maxking commented Aug 24, 2019

  • bpo-37461: Fix infinite loop in parsing of specially crafted email headers.

Some crafted email header would cause the get_parameter method to run in an
infinite loop causing a DoS attack surface when parsing those headers. This
patch fixes that by making sure the DQUOTE character is handled to prevent
going into an infinite loop.
(cherry picked from commit a4a994b)

Co-authored-by: Abhilash Raj [email protected]

https://bugs.python.org/issue37461

…ail headers (pythonGH-14794)

* bpo-37461: Fix infinite loop in parsing of specially crafted email headers.

Some crafted email header would cause the get_parameter method to run in an
infinite loop causing a DoS attack surface when parsing those headers. This
patch fixes that by making sure the DQUOTE character is handled to prevent
going into an infinite loop.
(cherry picked from commit a4a994b)

Co-authored-by: Abhilash Raj <[email protected]>
@maxking maxking requested a review from larryhastings August 24, 2019 04:55
@bedevere-bot bedevere-bot added the type-security A security issue label Aug 24, 2019
@maxking maxking changed the title [3.5] bpo-37461: Fix infinite loop in parsing of specially crafted em… [3.5] bpo-37461: Fix infinite loop in parsing of specially crafted email headers (GH-14794) Aug 24, 2019
@larryhastings larryhastings merged commit c28e4a5 into python:3.5 Sep 7, 2019
@bedevere-bot
Copy link

@larryhastings: Please replace # with GH- in the commit message next time. Thanks!

@larryhastings
Copy link
Contributor

Thanks for the 3.5 backport love!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-security A security issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants