bpo-30347: Fixed a crash in itertools.groupby() when use the grouper #1557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iterator in the key function.
serhiy-storchaka
added
type-bug
|
@serhiy-storchaka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rhettinger, @kristjanvalur and @birkenfeld to be potential reviewers. |
brettcannon
reviewed
May 12, 2017
Misc/NEWS
Outdated
| Library | ||
| ------- | ||
|
|
||
| - bpo-30347: Fixed a crash in itertools.groupby() when use the grouper iterator |
Contributor
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6. |
Contributor
|
Sorry @serhiy-storchaka, I had trouble checking out the |
|
GH-3770 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 26, 2017
…s.groupby() iterators. (pythonGH-1557) (cherry picked from commit c740e4f)
serhiy-storchaka
pushed a commit
that referenced
this pull request
Sep 26, 2017
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this pull request
Sep 26, 2017
…s.groupby() iterators. (pythonGH-1557). (cherry picked from commit c740e4f)
|
GH-3772 is a backport of this pull request to the 2.7 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Sep 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iterator in the key function.
https://bugs.python.org/issue30347