Remove macOS tests from Travis. #15809
Conversation
Azure runs macOS, so we don't need Travis to do it.
|
Is overlap the only motivation for removal here? I don't think overlap is necessarily bad, after all we run Linux on both Travis and Azure as well. Windows is run on Azure and AppVeyor. The redundancy helps to figure out flaky tests/race conditions and provides some actionable information in case a particular provider goes down. |
|
On Mon, Sep 9, 2019, at 18:11, Ammar Askar wrote:
Is overlap the only motivation for removal here? I don't think overlap
is necessarily bad, after all we run Linux on both Travis and Azure as
well.
The overlap isn't free, though. Duplicated work takes up finite CI resources. It's also true that the more things we run the more likely we are to see flakes.
|
|
I agree with this particular one, since the Travis resources are limited. I'd prefer to keep as many parallel builds as we can though, especially cross-CI system, as that gives us better representation of different user environments. |
|
Thanks @benjaminp for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
|
GH-15831 is a backport of this pull request to the 3.8 branch. |
ned-deily
left a comment
ned-deily
left a comment
There was a problem hiding this comment.
I think that running the tests under macOS on Travis has not proved to be very effective at finding real problems so I support making this change. Thanks!
Azure runs macOS, so we don't need Travis to do it. (cherry picked from commit e45b217) Co-authored-by: Benjamin Peterson <[email protected]>
Azure runs macOS, so we don't need Travis to do it.
Azure runs macOS, so we don't need Travis to do it.