Skip to content

[3.8] Revert "bpo-33418: Add tp_clear for function object (GH-8058)" #15826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Yhg1s merged 1 commit into from
Sep 10, 2019
Merged

[3.8] Revert "bpo-33418: Add tp_clear for function object (GH-8058)" #15826

Yhg1s merged 1 commit into from
Sep 10, 2019

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Sep 10, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Sep 10, 2019
@vstinner vstinner requested a review from methane September 10, 2019 07:41
@Yhg1s Yhg1s merged commit ccaea52 into python:3.8 Sep 10, 2019
@vstinner vstinner deleted the revert_func_clear branch September 10, 2019 14:31
nascheme added a commit to nascheme/cpython that referenced this pull request Sep 30, 2019
@nascheme
Restore tp_clear for function object.
8cbe5ae 
This is a revert of the revert (pythonGH-15826).  Having a tp_clear for
functions should be safe (and helpful) now that bpo-38006 has been
fixed.
@nascheme nascheme mentioned this pull request Sep 30, 2019
Merged
ambv pushed a commit that referenced this pull request Oct 1, 2019
@nascheme @ambv
Restore tp_clear for function object. (#16502)
b361207 
This is a revert of the revert (GH-15826).  Having a tp_clear for
functions should be safe (and helpful) now that bpo-38006 has been
fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@methane methane Awaiting requested review from methane

Assignees

No one assigned

Labels

skip news type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vstinner @Yhg1s @the-knights-who-say-ni @bedevere-bot