Skip to content

Conversation

@zooba
Copy link
Member

@zooba zooba commented Sep 10, 2019

Copy link
Member

@zware zware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zware zware merged commit 97d7906 into python:master Sep 10, 2019
@miss-islington
Copy link
Contributor

Thanks @zooba for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @zooba and @zware, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 97d7906e30eeee1261b20a45a22242a8accb1cfb 3.8

@miss-islington
Copy link
Contributor

Sorry, @zooba and @zware, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 97d7906e30eeee1261b20a45a22242a8accb1cfb 3.7

@zooba zooba deleted the bpo-38087 branch September 10, 2019 13:52
@zooba zooba assigned zooba and unassigned zware Sep 10, 2019
@bedevere-bot
Copy link

GH-15858 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-15859 is a backport of this pull request to the 3.8 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OS-windows tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants