bpo-38249: Expand Py_UNREACHABLE() to __builtin_unreachable() in the release mode. #16329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammaraskar
reviewed
Sep 22, 2019
vstinner
reviewed
Mar 9, 2020
Co-Authored-By: Victor Stinner <[email protected]>
…y-storchaka/cpython into Py_UNREACHABLE-builtin_unreachable
Member
Author
|
Thank you for your suggestions Victor and Ammar! |
vstinner
approved these changes
Mar 9, 2020
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM.
With the updated doc, it is easier for me to tell that the PR is consistent :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue38249