bpo-37838: get_type_hints for wrapped functions with forward reference #17126

benedwards14 · 2019-11-12T15:19:19Z

https://bugs.python.org/issue37838

brandtbucher

This looks like a good change to me! Just a few comments below to fix CI and clean things up.

brandtbucher · 2019-11-12T17:49:22Z

Lib/test/ann_module.py

+def dec(func):
+    def wrapper(*args, **kwargs):
+        return func(*args, **kwargs)
+    return wraps(func)(wrapper)


I think the tests are failing because of this missing newline:

Suggested change

return wraps(func)(wrapper)

return wraps(func)(wrapper)

Lib/test/ann_module.py

brandtbucher · 2019-11-12T17:53:12Z

Lib/test/test_typing.py


+class ForRefExample():
+    @ann_module.dec
+    def func(a: 'ForRefExample'):


Minor, but maybe just name this argument self for cleanliness?

Suggested change

def func(a: 'ForRefExample'):

def func(self: 'ForRefExample'):

brandtbucher · 2019-11-12T17:53:59Z

Lib/test/test_typing.py

+
+    @ann_module.dec
+    @ann_module.dec
+    def nested(a: 'ForRefExample'):


See above:

Suggested change

def nested(a: 'ForRefExample'):

def nested(self: 'ForRefExample'):

brandtbucher · 2019-11-12T17:54:14Z

Lib/test/test_typing.py

        self.assertEqual(gth(G), {'lst': ClassVar[List[T]]})

+    def test_get_type_hints_wrapped_decoratored_func(self):
+        expects = {'a': ForRefExample}


See above:

Suggested change

expects = {'a': ForRefExample}

expects = {'self': ForRefExample}

brandtbucher · 2019-11-12T17:58:43Z

Thanks for the PR @benedwards14!

This one should also have a NEWS entry. Just something simple, like:

:meth:`typing.get_type_hints` properly handles functions decorated with :meth:`functors.wraps`.

benedwards14 · 2019-11-21T11:40:46Z

Hey @brandtbucher, thanks for the review. Here are the markups.

brandtbucher

Looks good! Just a couple of remaining style nitpicks:

brandtbucher · 2019-11-21T14:19:31Z

Lib/test/test_typing.py


 gth = get_type_hints

+class ForRefExample():


No parentheses here, and 2 blank lines between top-level definitions:

Suggested change

class ForRefExample():

class ForRefExample:

Lib/test/test_typing.py

brandtbucher

Sorry, one last typo I spotted. Then good!

Misc/NEWS.d/next/Library/2019-11-21-11-39-17.bpo-37838.lRFcEC.rst

Co-Authored-By: Brandt Bucher <[email protected]>

brandtbucher · 2019-11-21T17:18:54Z

@ilevkivskyi

ilevkivskyi

Looks good, thanks!

ilevkivskyi · 2019-11-21T17:23:52Z

(Added backport labels since this is a bugfix.)

miss-islington · 2019-11-21T17:25:01Z

Thanks @benedwards14 for the PR, and @ilevkivskyi for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

bedevere-bot · 2019-11-21T17:25:14Z

GH-17324 is a backport of this pull request to the 3.8 branch.

bedevere-bot · 2019-11-21T17:25:22Z

GH-17325 is a backport of this pull request to the 3.7 branch.

pythonGH-17126) https://bugs.python.org/issue37838 (cherry picked from commit 0aca3a3) Co-authored-by: benedwards14 <[email protected]>

GH-17126) https://bugs.python.org/issue37838 (cherry picked from commit 0aca3a3) Co-authored-by: benedwards14 <[email protected]>

pythonGH-17126) https://bugs.python.org/issue37838

bpo-37838: get_type_hints for wrapped functions with forward reference

5fbdc0c

benedwards14 requested review from gvanrossum and ilevkivskyi as code owners November 12, 2019 15:19

the-knights-who-say-ni added the CLA signed label Nov 12, 2019

bedevere-bot added the awaiting review label Nov 12, 2019

brandtbucher requested changes Nov 12, 2019

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels Nov 12, 2019

brandtbucher added the type-bug An unexpected behavior, bug, or error label Nov 12, 2019

Benjamin Edwards and others added 2 commits November 21, 2019 03:37

Review Markups

a7e0bc9

📜🤖 Added by blurb_it.

4ed0118

brandtbucher requested changes Nov 21, 2019

View reviewed changes

Review Markups

f9d9e2c

brandtbucher requested changes Nov 21, 2019

View reviewed changes

Misc/NEWS.d/next/Library/2019-11-21-11-39-17.bpo-37838.lRFcEC.rst Outdated Show resolved Hide resolved

Update Misc/NEWS.d/next/Library/2019-11-21-11-39-17.bpo-37838.lRFcEC.rst

f7815a2

Co-Authored-By: Brandt Bucher <[email protected]>

ilevkivskyi approved these changes Nov 21, 2019

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting core review labels Nov 21, 2019

ilevkivskyi added needs backport to 3.7 labels Nov 21, 2019

ilevkivskyi merged commit 0aca3a3 into python:master Nov 21, 2019

bedevere-bot removed the awaiting merge label Nov 21, 2019

bedevere-bot removed the needs backport to 3.8 label Nov 21, 2019

sthagen mentioned this pull request Nov 21, 2019

bpo-37838: get_type_hints for wrapped functions with forward referenc… sthagen/python-cpython#39

Merged

bedevere-bot removed the needs backport to 3.7 label Nov 21, 2019

miss-islington added a commit that referenced this pull request Nov 21, 2019

bpo-37838: get_type_hints for wrapped functions with forward reference (

30e5bd8

GH-17126) https://bugs.python.org/issue37838 (cherry picked from commit 0aca3a3) Co-authored-by: benedwards14 <[email protected]>

miss-islington added a commit that referenced this pull request Nov 21, 2019

bpo-37838: get_type_hints for wrapped functions with forward reference (

9458c5c

GH-17126) https://bugs.python.org/issue37838 (cherry picked from commit 0aca3a3) Co-authored-by: benedwards14 <[email protected]>

jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull request Dec 5, 2019

bpo-37838: get_type_hints for wrapped functions with forward reference (

d582608

pythonGH-17126) https://bugs.python.org/issue37838

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request Jan 31, 2020

bpo-37838: get_type_hints for wrapped functions with forward reference (

6d41fe9

pythonGH-17126) https://bugs.python.org/issue37838

	def func(a: 'ForRefExample'):
	def func(self: 'ForRefExample'):

	def nested(a: 'ForRefExample'):
	def nested(self: 'ForRefExample'):

	expects = {'a': ForRefExample}
	expects = {'self': ForRefExample}

Uh oh!

bpo-37838: get_type_hints for wrapped functions with forward reference #17126

bpo-37838: get_type_hints for wrapped functions with forward reference #17126

Uh oh!

Conversation

benedwards14 commented Nov 12, 2019 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brandtbucher left a comment

Choose a reason for hiding this comment

Uh oh!

brandtbucher Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brandtbucher Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

brandtbucher Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

brandtbucher Nov 12, 2019

Choose a reason for hiding this comment

Uh oh!

brandtbucher commented Nov 12, 2019

Uh oh!

benedwards14 commented Nov 21, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

brandtbucher left a comment

Choose a reason for hiding this comment

Uh oh!

brandtbucher Nov 21, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

brandtbucher left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

brandtbucher commented Nov 21, 2019

Uh oh!

ilevkivskyi left a comment

Choose a reason for hiding this comment

Uh oh!

ilevkivskyi commented Nov 21, 2019

Uh oh!

miss-islington commented Nov 21, 2019

Uh oh!

bedevere-bot commented Nov 21, 2019

Uh oh!

bedevere-bot commented Nov 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

benedwards14 commented Nov 12, 2019 •

edited by bedevere-bot

Loading

benedwards14 commented Nov 21, 2019 •

edited

Loading