bpo-26730: Fix SpooledTemporaryFile data corruption #17400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpooledTemporaryFile.rollback() might cause data corruption when it is in text mode.
methane
added
needs backport to 3.7
type-bug
serhiy-storchaka
approved these changes
Nov 27, 2019
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
I am not sure about the function to class change. Let to left this to other issue. It needs a separate discussion. It might be discussed earlier.
Contributor
|
Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 27, 2019
SpooledTemporaryFile.rollback() might cause data corruption when it is in text mode. Co-Authored-By: Serhiy Storchaka <[email protected]> (cherry picked from commit ea9835c) Co-authored-by: Inada Naoki <[email protected]>
|
GH-17405 is a backport of this pull request to the 3.8 branch. |
Contributor
|
Sorry, @methane, I could not cleanly backport this to |
methane
added a commit
that referenced
this pull request
Nov 27, 2019
SpooledTemporaryFile.rollback() might cause data corruption when it is in text mode. Co-Authored-By: Serhiy Storchaka <[email protected]>. (cherry picked from commit ea9835c) Co-authored-by: Inada Naoki <[email protected]>
|
GH-17407 is a backport of this pull request to the 3.7 branch. |
miss-islington
added a commit
that referenced
this pull request
Nov 28, 2019
SpooledTemporaryFile.rollback() might cause data corruption when it is in text mode. Co-Authored-By: Serhiy Storchaka <[email protected]> (cherry picked from commit ea9835c) Co-authored-by: Inada Naoki <[email protected]>
methane
added a commit
that referenced
this pull request
Nov 28, 2019
SpooledTemporaryFile.rollback() might cause data corruption when it is in text mode. Co-Authored-By: Serhiy Storchaka <[email protected]>. (cherry picked from commit ea9835c)
jacobneiltaylor
pushed a commit
to jacobneiltaylor/cpython
that referenced
this pull request
Dec 5, 2019
SpooledTemporaryFile.rollback() might cause data corruption when it is in text mode. Co-Authored-By: Serhiy Storchaka <[email protected]>
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Jan 31, 2020
SpooledTemporaryFile.rollback() might cause data corruption when it is in text mode. Co-Authored-By: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue26730